Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@LeoGuo621
Copy link
Contributor

@LeoGuo621 LeoGuo621 commented Jul 10, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@LeoGuo621 LeoGuo621 marked this pull request as draft July 10, 2023 10:45
@codecov-commenter
Copy link

codecov-commenter commented Jul 10, 2023

Codecov Report

Merging #3203 (a08b465) into dev (39c86b1) will increase coverage by 0.11%.
The diff coverage is 92.59%.

❗ Current head a08b465 differs from pull request most recent head f6b2fd9. Consider uploading reports for the commit f6b2fd9 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #3203      +/-   ##
==========================================
+ Coverage   36.46%   36.57%   +0.11%     
==========================================
  Files         444      444              
  Lines       46606    46633      +27     
==========================================
+ Hits        16993    17056      +63     
+ Misses      28347    28310      -37     
- Partials     1266     1267       +1     
Impacted Files Coverage Δ
app/test_helpers.go 92.15% <92.59%> (+0.49%) ⬆️

... and 2 files with indirect coverage changes

@LeoGuo621 LeoGuo621 requested a review from scf0220 July 19, 2023 10:02
@LeoGuo621 LeoGuo621 marked this pull request as ready for review July 19, 2023 10:02
@KamiD KamiD merged commit f438319 into dev Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants