Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@FineKe
Copy link
Contributor

@FineKe FineKe commented Jul 5, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@FineKe FineKe requested a review from giskook July 5, 2023 01:53
@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023

Codecov Report

Merging #3193 (c0afb55) into dev (9483c69) will increase coverage by 6.66%.
The diff coverage is 0.00%.

❗ Current head c0afb55 differs from pull request most recent head 8518b52. Consider uploading reports for the commit 8518b52 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #3193      +/-   ##
==========================================
+ Coverage   29.80%   36.46%   +6.66%     
==========================================
  Files          54      444     +390     
  Lines        5838    46606   +40768     
==========================================
+ Hits         1740    16995   +15255     
- Misses       3927    28346   +24419     
- Partials      171     1265    +1094     
Impacted Files Coverage Δ
app/app.go 80.81% <0.00%> (-0.15%) ⬇️
app/start_from_snapshot.go 0.00% <0.00%> (ø)

... and 389 files with indirect coverage changes

@KamiD KamiD merged commit c45db7d into dev Jul 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants