Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@xzav3r
Copy link
Contributor

@xzav3r xzav3r commented Jun 30, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@xzav3r xzav3r force-pushed the yxq/fix-cmtx-nonce branch from d43a964 to ec1b455 Compare June 30, 2023 08:58
@codecov-commenter
Copy link

Codecov Report

Merging #3190 (8ddb932) into dev (22376e2) will increase coverage by 0.95%.
The diff coverage is 0.00%.

❗ Current head 8ddb932 differs from pull request most recent head ec1b455. Consider uploading reports for the commit ec1b455 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##              dev    #3190      +/-   ##
==========================================
+ Coverage   36.55%   37.51%   +0.95%     
==========================================
  Files         443      389      -54     
  Lines       46493    40665    -5828     
==========================================
- Hits        16996    15254    -1742     
+ Misses      28232    24316    -3916     
+ Partials     1265     1095     -170     
Impacted Files Coverage Δ
x/evm/types/msg_evm.go 73.18% <0.00%> (-0.57%) ⬇️

... and 55 files with indirect coverage changes

@KamiD KamiD merged commit 691f8c3 into dev Jul 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants