Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@BananaLF
Copy link
Collaborator

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented May 30, 2023

Codecov Report

Merging #3157 (485687f) into dev (8468d8d) will not change coverage.
The diff coverage is n/a.

❗ Current head 485687f differs from pull request most recent head 03cd000. Consider uploading reports for the commit 03cd000 to get more accurate results

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff           @@
##              dev    #3157   +/-   ##
=======================================
  Coverage   36.55%   36.55%           
=======================================
  Files         443      443           
  Lines       46486    46486           
=======================================
  Hits        16993    16993           
  Misses      28228    28228           
  Partials     1265     1265           

@BananaLF BananaLF force-pushed the sunstrider/static_compile branch from 14385fb to f87c9e4 Compare May 30, 2023 08:44
@KamiD KamiD merged commit 0274e47 into dev Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants