Skip to content
This repository was archived by the owner on Aug 23, 2025. It is now read-only.

Conversation

@giskook
Copy link
Contributor

@giskook giskook commented Apr 12, 2023

  • Targeted PR against correct branch (see CONTRIBUTING.md)

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

  • Wrote tests

  • Updated relevant documentation (docs/)

  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md

  • Reviewed Files changed in the github PR explorer


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge PR #XYZ: [title]" (coding standards)

@codecov-commenter
Copy link

codecov-commenter commented Apr 12, 2023

Codecov Report

Merging #3095 (71725e2) into dev (ab28f14) will increase coverage by 0.67%.
The diff coverage is n/a.

❗ Current head 71725e2 differs from pull request most recent head 9e56daf. Consider uploading reports for the commit 9e56daf to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##              dev    #3095      +/-   ##
==========================================
+ Coverage   35.91%   36.59%   +0.67%     
==========================================
  Files         434      382      -52     
  Lines       45779    40199    -5580     
==========================================
- Hits        16441    14710    -1731     
+ Misses      28149    24465    -3684     
+ Partials     1189     1024     -165     

see 52 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@giskook giskook force-pushed the zhangkai/wasm-sim-gas-limit branch from 00259f2 to 0eaef9f Compare April 12, 2023 08:21
@giskook giskook marked this pull request as ready for review April 12, 2023 08:35
@giskook giskook force-pushed the zhangkai/wasm-sim-gas-limit branch from c1b7804 to 9e56daf Compare April 12, 2023 08:46
@KamiD KamiD merged commit 9fb2deb into dev Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants