[FIX] app: take into account config.dev if it is set
#1740
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
__Behavior before commit:__ When [`mountWithCleanup`] is called, the config to create a new instance of `App` contains `dev: false` and `test: true`. In the constructor of [`TemplateSet`], `this.dev` is set to `config.dev` but it's then it's overwritten in the constructor of `App` if `config.test` is set. This has the annoying side-effect of calling `wrapError` during Hoot tests, which adds quite a big performance and memory overhead. __Fix:__ Make sure that `this.dev` is set to `config.dev` even if `config.test` is `true`. [`mountWithCleanup`]: https://github.com/odoo/odoo/blob/7fd5f90fe8fce4de49ec10c683f92e7a3557981a/addons/web/static/tests/_framework/component_test_helpers.js#L138 [`TemplateSet`]: https://github.com/odoo/owl/blob/4e834369527f5d747de8f13236504dc20731c1c8/src/runtime/template_set.ts#L38 task-5269391
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Behavior before commit:
When
mountWithCleanupis called, the config to create a new instanceof
Appcontainsdev: falseandtest: true.In the constructor of
TemplateSet,this.devis set toconfig.devbut it's then it's overwritten in the constructor of
Appifconfig.testis set.This has the annoying side-effect of calling
wrapErrorduring Hoottests, which adds quite a big performance and memory overhead.
Fix:
Make sure that
this.devis set toconfig.deveven ifconfig.testis
true.task-5269391