-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[IMP] Fleet: Update services #13268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Fleet: Update services #13268
Conversation
a500940
to
32d0816
Compare
Hi @slinkous - this is ready for a review! |
32d0816
to
2b857b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I was maybe having too much fun with comments. A couple of usage suggestions.
Service types must be created from a service form. There is no other way to access the list of | ||
service types. | ||
Service types should be created from a :ref:`service form <fleet/service-form>`. No other way exists | ||
to access the list of service types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming this was a style guide conformity thing, but "No other way exists" is a cursed-sounding construction. Shikata ga nai.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup! I believe this was an edit from someone else? I can't honestly remember, but it was super-important to mention (and kind of odd for Odoo to do it this way).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this thread is so funny I had to unresolve just to react 😂
2b857b7
to
2485fdc
Compare
Hi @Felicious - this is ready for a final review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @larm-odoo !
Service types must be created from a service form. There is no other way to access the list of | ||
service types. | ||
Service types should be created from a :ref:`service form <fleet/service-form>`. No other way exists | ||
to access the list of service types. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this thread is so funny I had to unresolve just to react 😂
2485fdc
to
5ecca85
Compare
Hi @samueljlieber - this is ready for a tech review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great @larm-odoo, nice clean-up on this doc too. Thank you!
...
@robodoo r+
Updating to new standards