Skip to content

Allow <div> & script-supporting element in <dl> #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
toastal wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Allow <div> & script-supporting element in <dl> #344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ebb4abd
Add script-supporting elements
toastal Jun 21, 2025
a786a08
Allow `<div>` & script-supporting element in `<dl>`
toastal Jun 21, 2025
948c3a2
update CHANGES.md
toastal Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,9 @@
(#333 by Martin @MBodin Bodin)
* Fix typo for `subresource` & English orthographic fixes
(#345 by toastal)
* Allow `<div>` to wrap `<dd>` / `<dt>` as well as script-supporting elements
in `<dl>`
(#344 by toastal)

# 4.6.0

Expand Down
13 changes: 8 additions & 5 deletions lib/html_types.mli
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -427,6 +427,9 @@ type formassociated = [ | listed | `Progress | `Meter | `Label ]
type subresource_integrity = [ | `Crossorigin | `Integrity ]
(** @see <https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity> *)

type script_supporting = [ | `Script | `Template ]
(** @see <https://developer.mozilla.org/en-US/docs/Glossary/Script-supporting_element> *)

(** Transparent elements.
Such elements have a part of they children in their data
and behaves like them. We could do something like [a: 'a elt list -> 'a elt]
Expand Down Expand Up @@ -1423,12 +1426,12 @@ type dialog_content_fun = [ | flow5 ]

type dialog_attrib = [ | common | `Open ]

(* NAME: div, KIND: star, TYPE: [= common ], [= flow5 ], [=`Div], ARG: [= flow5 ], ATTRIB: OUT: [=`Div] *)
(* NAME: div, KIND: star, TYPE: [= common ], [= flow5 | `Dd | `Dt ], [=`Div], ARG: [= flow5 ], ATTRIB: OUT: [=`Div] *)
type div = [ | `Div ]

type div_content = [ | flow5 ]
type div_content = [ | flow5 | `Dd | `Dt ]

type div_content_fun = [ | flow5 ]
type div_content_fun = [ | flow5 | `Dd | `Dt ]

type div_attrib = [ | common ]

Expand Down Expand Up @@ -1479,9 +1482,9 @@ type dt_attrib = [ | common ]

type dl = [ | `Dl ]

type dl_content = [ | `Dt | `Dd ]
type dl_content = [ | script_supporting | `Div | `Dd | `Dt ]

type dl_content_fun = [ | `Dt | `Dd ]
type dl_content_fun = [ | script_supporting | `Div | `Dd | `Dt ]

type dl_attrib = [ | common ]

Expand Down
Loading