frontend: Switch off deleted scenes immediately #12900
Open
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exeldro
reviewed
Dec 9, 2025
RytoEX
requested review from
PatTheMav and
exeldro
and removed request for
exeldro
PatTheMav
reviewed
Dec 10, 2025
Warchamp7
force-pushed
the
scene-delete-transitions
branch
from
0950cbc to
81c2ec7
Compare
Contributor
|
The changes look good to me. There is a review requested from me, but I don't have the rights to approve. |
PatTheMav
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Companion PR to #12882. When a scene has been removed and it was the previously active scene, switch immediately off of it.
Motivation and Context
Fixes #12880 on the frontend side whereas #12882 fixes it on the libobs side. Both solutions are good:
libobsshould immediately cease using any source marked as removed and the frontend should avoid puttinglibobsin a state where it needs to.How Has This Been Tested?
Deleted multiple scenes that contained Audio Input/Output captures. Performed transitions after deleting the scene and confirmed no "ghost" transitions happened caused by the scene still being held by the current transition.
Types of changes
Checklist: