open.no_window_picker fallback window should respect window_picker.exclude settings

[LucasMABF]

Description

When opening a file without the window picker, nvim-tree opens a buffer in the last active window, without considering the window_picker.exclude configuration. For instance, opening the tree while inside a terminal buffer will cause the next opened file to replace the terminal (given that it opens with open.no_window_picker).

I'm not sure if this is actually a bug or intended behavior. However, I was able to fix it with a small change in open-file.lua. I'll link a PR to this issue in case you find this change desirable.

nvim-tree version

master branch — commit 1c733e8

Clean room replication

Default nvt-min.lua minimal configuration

Steps to reproduce

1. Open a terminal and a file in a split
2. Focus the terminal window
3. Open tree
4. Open a file with "no picker" mode (O in default mapping)

Expected behavior

Nvim-tree should open the file in a window considering the window_picker.exclude configuration.

Actual behavior

Nvim-tree opens the file in the last active window, disregarding any configuration and buffer type.

---

Thanks for your time

[alex-courtis]

This could be considered a break in functionality, however it's sensible and users can control this behaviour via exclude.