Skip to content

fix(module): fix parsing bug for .npmrc files with comments #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 10, 2025

Conversation

odanado
Copy link
Contributor

@odanado odanado commented May 15, 2025

πŸ”— Linked issue

resolves #880

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

I have fixed a bug where parsing the registry URL fails when .npmrc contains comments.

@odanado odanado requested a review from danielroe as a code owner May 15, 2025 18:16
@odanado odanado force-pushed the add-confbox-for-parsing-npmrc branch from 0631b23 to f476de4 Compare May 26, 2025 16:32
@codecov-commenter
Copy link

codecov-commenter commented May 26, 2025

Codecov Report

Attention: Patch coverage is 73.91304% with 6 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@baf6988). Learn more about missing BASE report.

Files with missing lines Patch % Lines
packages/nuxi/src/commands/module/_utils.ts 84.21% 3 Missing ⚠️
packages/nuxi/src/commands/module/add.ts 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #881   +/-   ##
=======================================
  Coverage        ?   12.90%           
=======================================
  Files           ?       71           
  Lines           ?     3734           
  Branches        ?      108           
=======================================
  Hits            ?      482           
  Misses          ?     3220           
  Partials        ?       32           

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

pkg-pr-new bot commented May 26, 2025

Open in StackBlitz

npm i https://pkg.pr.new/create-nuxt@881
npm i https://pkg.pr.new/nuxi@881
npm i https://pkg.pr.new/@nuxt/cli@881

commit: 50e96f8

@odanado
Copy link
Contributor Author

odanado commented May 26, 2025

@danielroe
Sorry for the late reply.
Could you please review this?

The following error is occurring in CI, but it seems to be a permissions issue with GitHub Actions, so I probably can't resolve it myself.

Error: Resource not accessible by integration - https://docs.github.com/rest/issues/comments#create-an-issue-comment

https://github.com/nuxt/cli/actions/runs/15258663204/job/42912106037

@danielroe danielroe changed the title fix(nuxi): fix parsing bug for .npmrc files with comments fix(module): fix parsing bug for .npmrc files with comments Jun 10, 2025
Copy link

codspeed-hq bot commented Jun 10, 2025

CodSpeed Performance Report

Merging #881 will not alter performance

Comparing odanado:add-confbox-for-parsing-npmrc (50e96f8) with main (baf6988)

Summary

βœ… 2 untouched benchmarks

@danielroe danielroe merged commit 4ac8e3d into nuxt:main Jun 10, 2025
11 of 14 checks passed
@github-actions github-actions bot mentioned this pull request Jun 10, 2025
@odanado odanado deleted the add-confbox-for-parsing-npmrc branch June 10, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When .npmrc contains comments, the nuxi module add command fails.
3 participants