fix: make errors returned by useLazyAsync reactive #1004
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wattanx
force-pushed
the
fix/use-lazy-async-data-error
branch
from
d82b749 to
6d76c0e
Compare
wattanx
force-pushed
the
fix/use-lazy-async-data-error
branch
from
6d76c0e to
eb19428
Compare
danielroe
reviewed
Dec 11, 2023
| data: _ref(options.getCachedData!(key) ?? options.default!()), | ||
| pending: ref(!hasCachedData()), | ||
| error: toRef(nuxt.payload._errors, key), | ||
| error: ref(nuxt.payload._errors[key]), |
Member
There was a problem hiding this comment.
I believe this will mean that the error is 'disconnected' from the payload and won't be included in it.
Is there a reason that toRef isn't reactive here? If so, we might need to add an additional assignment to the payload when the error is thrown below.
Collaborator
Author
There was a problem hiding this comment.
Ah, it seems this wasn't essential. It might be because _errors is not reactive.
wattanx
force-pushed
the
fix/use-lazy-async-data-error
branch
from
eb19428 to
22b5f6c
Compare
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 Linked issue
#1001
❓ Type of change
📚 Description
The error returned by useLazyAsyncData remained null even if there was an error. (if ssr: false)
Fixed to behave the same as nuxt 3.
https://stackblitz.com/edit/github-drhhpj-bd1bnm
📝 Checklist