Fix issues no. 431: modify theme switcher logic to show next theme icon #434
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #431 by updating the theme switcher UI so the button displays the mode that will be applied when clicked (i.e. it now shows the next theme icon). Previously the button showed the current theme, which is confusing.
What I changed
html[data-theme]changes.Why this fixes the issue
Users expect a toggle to indicate the action that will happen when pressed. Showing the opposite icon reduces confusion and follows common UI patterns.
Testing