Skip to content

implement escaping of %% to \% #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025
Merged

implement escaping of %% to \% #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Sources/StringCatalogConverterLibrary/StringCatalog+Conversion.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ extension StringCatalog {
.replacingOccurrences(of: "'", with: "\\'")
.replacingOccurrences(of: "%@", with: "%1$s")
.replacingOccurrences(of: "%d", with: "%2$d")
.replacingOccurrences(of: "%%", with: "\\%") // https://stackoverflow.com/a/74864023
}

public func converted(
Expand Down
20 changes: 19 additions & 1 deletion Tests/StringCatalogConverterLibraryTests/Resources/SimpleTest/Input.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,24 @@
}
}
},
"concentrationPercent" : {
"comment" : "Label that represents the concentration of a solution in percent",
"extractionState" : "manual",
"localizations" : {
"de" : {
"stringUnit" : {
"state" : "needs_review",
"value" : "Konzentration in %%"
}
},
"en" : {
"stringUnit" : {
"state" : "translated",
"value" : "concentration in %%"
}
}
}
},
"counter.button" : {
"extractionState" : "manual",
"localizations" : {
Expand Down Expand Up @@ -466,4 +484,4 @@
}
},
"version" : "1.0"
}
}
1 change: 1 addition & 0 deletions Tests/StringCatalogConverterLibraryTests/Resources/SimpleTest/Output.de.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<string name="child_button">Child Tap</string>
<string name="collection_empty_message">Es sind keine Elemente anzuzeigen</string>
<string name="collection_item">Element %1$s</string>
<string name="concentrationPercent">Konzentration in \%</string>
<string name="counter_button">Tap</string>
<string name="counter_status_text">Anzahl der Child Taps: %2$d</string>
<string name="counter_website">Number42 Website</string>
Expand Down
1 change: 1 addition & 0 deletions Tests/StringCatalogConverterLibraryTests/Resources/SimpleTest/Output.en.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
<string name="child_button">Child Tap</string>
<string name="collection_empty_message">There are no items to show</string>
<string name="collection_item">Item %1$s</string>
<string name="concentrationPercent">concentration in \%</string>
<string name="counter_button">Tap</string>
<string name="counter_status_text">Number of Child Taps: %2$d</string>
<string name="counter_website">Number42 Website</string>
Expand Down