fix: use URL.canParse instead of runtime deprecated url.parse api
#247
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperchupuDev
force-pushed
the
refactor/no-deprecated-url-parse
branch
from
5a5764a to
26419a3
Compare
|
Looks like we have an unreleased version ready to go so I'll open and land this. But just heads up this is imminently being deprecated. |
|
I can not reopen this cause of auto branch deletion :/ Sorry about that. I'll land this if you reopen it. |
|
i've restored the branch, it should be reopenable now i think? |
wraithgar
approved these changes
Jul 22, 2025
Merged
wraithgar
pushed a commit
that referenced
this pull request
Jul 22, 2025
🤖 I have created a release *beep* *boop* --- ## [7.0.1](v7.0.0...v7.0.1) (2025-07-22) ### Bug Fixes * [`97fb20a`](97fb20a) [#247](#247) use `URL.canParse` instead of runtime deprecated `url.parse` api (#247) (@SuperchupuDev) * [`cc37f25`](cc37f25) [#244](#244) use `isBuiltin` instead of `builtinModules` (#244) (@SuperchupuDev) ### Chores * [`acafa71`](acafa71) [#245](#245) bump @npmcli/template-oss from 4.24.4 to 4.25.0 (#245) (@dependabot[bot], @owlstronaut) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of npm/package-json#150
url.parseis runtime deprecated. It looks like it's being used here to somewhat check if the string is a valid URL, so I've changed that toURL.canParsewhich is the compliant way of checking whether a string is a valid and parsable URL.URL.canParsewas added in node18.17.0and19.9.0Closes #242
References
pnpm/pnpm#9529
https://developer.mozilla.org/en-US/docs/Web/API/URL/canParse_static
https://nodejs.org/api/url.html#urlcanparseinput-base