Skip all Modify events right after a Create event, unless it's a rename event
#701
+41
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rename event Fixes notify-rs#671
dfaust
force-pushed
the
fix-skip-modify-after-create
branch
from
9c71561 to
cbd1ac8
Compare
|
@JohnTitor can you please have a look at this? I think it would be a good time to cut a new release and I would like to include this fix. |
|
Yeah, indeed!.. When it's going to be released? 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #671.
Relies on backends never emitting a
Modifyevent with kind other thanNamefor a rename event.I checked and this is the case now and I don't see why that would change in the future.