GTM API integration #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stuartio Awesome... thank you. Reviewing this now. |
|
Also, the directory permssions on the ./akamai_gtm_cacher appear to be 777. Can you have them match the other 755? |
|
I believe @ccloes covered the extent of my feedback |
|
@stuartio can you also add a sanitized example json file for testing purposes? |
|
Hey guys, I have updated as per our discussion. Let me know if you want to tweak the data structure further |
|
Thanks @stuartio, I am out this week, but I will get this tested as soon as I get back. Thank you. |
|
Thanks @stuartio ... looks great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic listing of domains and iterative pull of each, outputting to a single json. No neo4j integrator as yet