Skip to content
This repository was archived by the owner on Mar 25, 2018. It is now read-only.
This repository was archived by the owner on Mar 25, 2018. It is now read-only.

SmartOS cannot build on master #1

Closed
@targos

Description

@targos

It seems that std::to_string does not exist on this platform ?

I tried to change the std flag to gnu++11 but get the same error:

g++ '-DV8_TARGET_ARCH_IA32' '-D__C99FEATURES__=1' '-DENABLE_DISASSEMBLER' '-DV8_I18N_SUPPORT' '-DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_STATIC' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' '-DUCONFIG_NO_LEGACY_CONVERSION=1' '-DUCONFIG_NO_CONVERSION=1' -I../deps/v8 -I../. -I/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/out/Release/obj/gen -I../deps/v8/include -I../deps/icu-small/source/i18n -I../deps/icu-small/source/common  -Wall -Wextra -Wno-unused-parameter -m32 -pthreads -msse2 -mfpmath=sse -mmmx -fno-strict-aliasing -m32 -O3 -fno-omit-frame-pointer -fno-rtti -fno-exceptions -std=gnu++11 -MMD -MF /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/out/Release/.deps//home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/out/Release/obj.target/v8_base/deps/v8/src/parsing/preparse-data.o.d.raw   -c -o /home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/out/Release/obj.target/v8_base/deps/v8/src/parsing/preparse-data.o ../deps/v8/src/parsing/preparse-data.cc
In file included from ../deps/v8/src/ast/modules.h:8:0,
                 from ../deps/v8/src/ast/ast.h:10,
                 from ../deps/v8/src/parsing/parser.h:8,
                 from ../deps/v8/src/parsing/parser.cc:5:
../deps/v8/src/parsing/scanner.h: In member function 'void v8::internal::Scanner::LiteralBuffer::AddChar(v8::internal::uc32)':
../deps/v8/src/parsing/scanner.h:372:43: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
         if (code_unit <= unibrow::Latin1::kMaxChar) {
                                           ^
../deps/v8/src/parsing/scanner.h:379:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
       if (code_unit <= unibrow::Utf16::kMaxNonSurrogateCharCode) {
                                        ^
../deps/v8/src/parsing/parser.cc: In function 'const v8::internal::AstRawString* v8::internal::ClassFieldVariableName(bool, v8::internal::AstValueFactory*, int)':
../deps/v8/src/parsing/parser.cc:3360:25: error: 'to_string' is not a member of 'std'
       ".class-field-" + std::to_string(index) + (is_name ? "-name" : "-func");
                         ^
deps/v8/src/v8_base.target.mk:587: recipe for target '/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos14-32/out/Release/obj.target/v8_base/deps/v8/src/parsing/parser.o' failed

Build: https://ci.nodejs.org/job/node-test-commit-smartos/4536/nodes=smartos14-32/console
/cc @nodejs/platform-solaris

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions