-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
chore(homepage): link to our blog, rather than HeroDevs #7883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Claudio W. <[email protected]>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updates the homepage’s secondary button to point to the official Node.js announcement for Node.js 18 EOL support instead of the external HeroDevs page.
- Replaced HeroDevs support link with Node.js blog announcement URL
- Button text and styling remain unchanged
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7883 +/- ##
==========================================
+ Coverage 75.45% 75.47% +0.02%
==========================================
Files 101 101
Lines 8311 8311
Branches 218 218
==========================================
+ Hits 6271 6273 +2
+ Misses 2038 2036 -2
Partials 2 2 ☔ View full report in Codecov by Sentry. |
I pre-emptively approve a future fast-track request under the condition that this receives TSC approval. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Dropping the red X on this to make sure it doesn't land without the TSC having the opportunity to discuss further. The change itself lgtm but we need to be clear on the intent and goal here. Linking to something other than directly to the Herodevs site might be contrary to the entire point.
Cc @nodejs/tsc please review |
Thanks for calling that out. My goal here was to help reduce the heat and confusion we're currently getting from parts of the community regarding the presence of a direct link to a 3rd-party site. This change is meant as a temporary measure — or potentially a longer-term solution, if it ends up being seen as a better compromise. I agree that we should align on the broader goals here, but I believe this could help ease some of the current friction in the meantime. |
Co-authored-by: Aviv Keller <[email protected]> Signed-off-by: Claudio W. <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it !
No, I explained why I blocked and that still stands. I want to make sure there's plenty of time for the TSC and Foundation to discuss. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than this was what I would've felt more comfortable with in the first place, I think in terms of protecting the image of the project this is a strict improvement (I am already seeing criticism about the current direct link on social media, both towards the project and towards the sponsor. Directing to an official blog post at least does enough as damage control).
Would you be willing to link to any criticisms you've seen? Given that one of the purposes of the link was to determine how effective such a link would be, such concrete feedback would be helpful. I've not seen any public criticism in social channels yet. |
I don't feel like adding a GitHub <-> social media feedback loop since that seems somewhat toxic, I will post it to the nodejs-social slack channel. |
👀 If/when this is given TSC approval, we should also make sure we have explicit approval from the Foundation for this change, as I understand it was a request from them to have this be a direct link rather than to our blog post. (I am very much +1 to this change, I think a first-party link that educates on EOL status, updating, etc. and gives context before sending users to the ESP is much more valuable to the community than a direct link to the ESP with very little context, but want to make sure we're fully aligned on this change and aren't falling foul of any requirements from the Foundation.) |
Personally I think having a distinct page on nodejs.org that describes the ESP specifically, and then in turn links to partners (HeroDevs at the moment, but obviously any additional partners in the future), would be a perfectly fine choice here - but a blog post where commercial support is mentioned in the 16th-18th paragraphs doesn't seem like it will move the needle for getting funding for the project, nor satisfy the ESP contract terms. |
Are we on a program different from what Vue.js is doing? Can that page be tweaked to be similar to https://v2.vuejs.org/eol/ and to be enough? I wonder where can we find the ESP contract, is that public, or at least the terms about promotional content? I did see some numbers that the project is getting but it was communicated in a private meeting, which was somewhat confusing to me - at the end of the day the project is a community-driven one and the foundation is a I feel that the amount of information being kept in private is more than necessary or counterproductive to make the program successful. If our collective goal is to keep enough traffic to the sponsor so that we have enough income for the CI infra to stay afloat, why not just disclose the traffic and the income, and we collectively work towards that goal in public? I think that might even be some positive publicity from this for the sponsor, instead of leaving people guessing what this whole program is about and assuming bad faith on social media. |
My exact thoughts. I could also set a permanent URL for /eol (FYI); But I'm also curious on why Vue can have a blog post and us not? To be clear, I'm fine having a dedicated "page" which honestly speaking can just be a blog post. I also thought that @rginn did write the blog post (and Matteo posted on her behalf); I'm also 👍 if we want to rephrase or update the blog post to better align with any contractaul terms. |
@jasnell apologies for me bothering you again, due to #7773 (comment) the button itself lost its value. I do believe we should merge this, otherwise the button is just simply not there for anyone using EasyList, which is incorporated on pretty much every AdBlocker be it browser-level or DNS level. |
I think you're vastly overestimating how many people use adblockers, especially in enterprise environments - I don't think its targeting by adblockers reduces its value at all, personally. |
|
As an enterprise user myself, I do use an adblocker. Do you have any data to support your claim? Specifically, can you provide statistics on what percentage of users accessing nodejs.org are doing so from enterprise or work environments? With all due respect, if major privacy filter lists are blocking the button, that alone significantly undermines its visibility and, by extension, its effectiveness. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
As mentioned, I was blocking only to ensure enough time was given to review before it was merged. I'm dismissing that block now. I disagree with this specific change in general but I am not blocking it.
This comment has been minimized.
This comment has been minimized.
|
Can you elaborate on why this is considered inappropriate? We are discussing a PR that affects the implementation of the ESP, and someone raised that it may not satisfy ESP terms, so I was asking whether the terms are public, and if not why can't we be more transparent about it. I think this is similar to be asking in a PR that implements a spec, someone raised that it may not be spec compliant, so I was asking for a reference in the spec, and why can't we be more transparent about the spec and the motivation of the part being implemented. And as @AugustinMauroy pointed, it seems the terms are public (unless, those are not terms), which explicitly listed the Vue.js page as a best practice. That seems to be a productive outcome from this discussion? I think all of the website stylistic changes we've discussed about are to bring a balance between community acceptance and making the income/expense match. That's why I am raising the question about why we can't be more transparent about the income/expense match, so that we'll have a way to figure out whether this stylistic change is doing enough, or whether other stylistic changes would help making the numbers match, if so, how much. This is a response to "how much the needled is being moved" comment by @ljharb . It seems unnecessarily difficult to move the needle if the needle has to be covered and we have a long latency between team A doing something to move the needle, and a different team B is notified whether the needle is moved and in which direction, and team B need to reach consensus about what to tell team A next. Considering this PR is basically team A implementing another proposal that would affect the needle, isn't this the right place to ask about why we have such an inefficient process about the needle? |
FYI that is not the contract, jsut the general ESP program guidelines/description/etc.
These are not (necessarily) the terms of the contract with HeroDevs (double FYI) 😅 |
This comment has been minimized.
This comment has been minimized.
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ESP is non-exclusive and open to other partners as well. So linking to a nodejs.org page rather than to a specific partner directly on the project homepage is strictly following the spirit of ESP.
All checks are green, @nodejs/TSC please merge when ready :-) |
Agreed, that said, I would prefer to see the dedicated ESP solution that has been proposed and I believe this change should be temporary while we work on that. IMO the ESP page is going to be a much better look on how the program is structured and in turn improve conversion which is the outcome desired for both the partner and the project. |
Okay, to leave a record for transparency, let us discuss this among the TSC, I'll cc the moderation team. |
fwiw the inefficiency on the feedback loop is not something that's fully solveable imo; sales cycles take a long time. Whatever node wants to attempt, it's likely going to have to sit there for 3-6 months before we can know what needs to be tweaked. |
I think having a 3-6 months delay is still better than keeping it completely opaque, IIUC there was already past data from when there was a link in the footer. Also so far it seems there are multiple messengers in the feedback loop each adding a layer of error to the feedback eventually reaching the team. We need to double check but from the TSC meeting today it seems the exact style of the current button is not a contractual requirement, but more of something that some people on the project/foundation's side believe would be helpful in driving the traffic, and we were given this document which explicitly listed the Vue.js example as reference. What I am getting is that there are multiple ways to do this:
I think everyone wants 2 but the communication error introduced by the layers so far made us think 3 is 2 and then 2 is 1. Having a better communication channel and tighter feedback loop would make sure that we stay close to 2. |
That's a good analysis - I think part of the problem, though, is that there are many different ideas of what "reputation expense" constitutes. |
Based on TSC discussion today this should not land until Monday June 30th as the TSC confirms that there is consensus that landing this is the appropriate next step. I won't be around Monday June 30th so please dismiss my block after having confirmed with a TSC member that consensus was reached. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking until we confirm we have TSC consensus on making the change.
I don't think it's a problem per say, all of Node.js is built using consensus seeking among people that have different ideas about virtually everything. This topic seems certainly to be more "touchy" than the average, but we've seen worse 😅 |
Adding a bit more info. This is the plan we are confirming that we have TSC consensus for:
|
It seems someone went ahead before consensus was reached https://x.com/nodejs/status/1938326519434363133 (without consulting the TSC as far as I know) I think the thread being reposted is a good basis for the content, though in principal it would've been better to make sure we are on board with the communication that represents the project before we post that as a communication that represents the project - ideally before even the button was landed, now that the button is landed, reposting an individual TSC member's response from their personal account as a remedy still seems better than being completely quiet, just that some review process seems missing - a fast tracked review process is still better than no review process at all and letting one individual's opinion represent the project without consulting others IMO. |
This PR proposes a quick improvement to the current homepage button that directly links to HeroDev's website.
It’s based on a suggestion by @joyeecheung to provide a clearer, more official announcement link.
cc @nodejs/tsc
Relates to #7773