Skip to content

Migrate detect os hook #5322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 18 commits into from
Apr 24, 2023
Merged

Migrate detect os hook #5322

merged 18 commits into from
Apr 24, 2023

Conversation

FHachez
Copy link
Contributor

@FHachez FHachez commented Apr 21, 2023 •
edited by ovflowd
Loading

Hey here is a first PR on the detect OS hook.

As discussed in the issue, I switch to relying on the userAgent on top of the appVersion, because the appVersion is deprecated.

  • I'm adding some tests.

@vercel
Copy link

vercel bot commented Apr 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 24, 2023 1:45pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview Apr 24, 2023 1:45pm

FHachez
FHachez commented Apr 21, 2023
View reviewed changes
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 16:56 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 16:56 Inactive
ovflowd
ovflowd approved these changes Apr 21, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff! Thank you for your first contribution!!

I've left a few comments 👀

(Don't forget to add tests before we get this merged) (Covering the util and the Hook separately)

@ovflowd ovflowd self-requested a review April 21, 2023 17:03
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 17:42 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 17:43 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 17:45 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 17:45 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 18:07 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 18:08 Inactive
@FHachez
Copy link
Contributor Author

FHachez commented Apr 21, 2023

@ovflowd thanks for the review, I've tackled the comments.

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 21, 2023 18:09 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 21, 2023 18:10 Inactive
shanpriyan
shanpriyan approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@shanpriyan shanpriyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the PR 🚀

@vercel vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 03:39 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 03:40 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 07:58 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 08:00 Inactive
ovflowd
ovflowd reviewed Apr 22, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool stuff! Those are really good contributions! Thank you for your effort <3

I left a few comments and suggestions 🙇

@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 10:28 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 10:29 Inactive
ovflowd
ovflowd reviewed Apr 22, 2023
View reviewed changes
FHachez
FHachez commented Apr 22, 2023
View reviewed changes
ovflowd
ovflowd reviewed Apr 22, 2023
View reviewed changes
ovflowd
ovflowd reviewed Apr 22, 2023
View reviewed changes
ovflowd
ovflowd reviewed Apr 22, 2023
View reviewed changes
ovflowd
ovflowd approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good stuff! Thank you for the changes. I left a few final comments, and we're ready to go!!

:shipit:

@vercel vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 10:36 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 10:37 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 22, 2023 10:46 Inactive
ovflowd
ovflowd approved these changes Apr 22, 2023
View reviewed changes
Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's get this merged! Congrats for your first contribution :)

@vercel vercel bot temporarily deployed to Preview – nodejs-org April 22, 2023 10:48 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories April 24, 2023 13:44 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org April 24, 2023 13:45 Inactive
@ovflowd ovflowd merged commit f49c166 into nodejs:major/website-redesign Apr 24, 2023
@ovflowd ovflowd mentioned this pull request Apr 24, 2023
Closed
ovflowd pushed a commit that referenced this pull request May 3, 2023
@FHachez @aymen94 @ovflowd
Migrate detect os hook (#5322)
d910567 
Co-authored-by: Wai.Tung <[email protected]>
Co-authored-by: Aymen Naghmouchi <[email protected]>
@HinataKah0 HinataKah0 mentioned this pull request Jun 8, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ovflowd ovflowd ovflowd approved these changes

@aymen94 aymen94 aymen94 approved these changes

@shanpriyan shanpriyan shanpriyan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@FHachez @ovflowd @aymen94 @shanpriyan