-
-
Notifications
You must be signed in to change notification settings - Fork 34k
process: optimize asyncHandledRejections by using FixedQueue #60854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review requested:
|
juanarbol
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Uzlopak
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60854 +/- ##
==========================================
- Coverage 88.56% 88.54% -0.03%
==========================================
Files 703 703
Lines 208259 208259
Branches 40187 40164 -23
==========================================
- Hits 184454 184411 -43
- Misses 15812 15836 +24
- Partials 7993 8012 +19
🚀 New features to boost your workflow:
|
branch:
main:
Using a regular Array for a queue that only shifts elements is inefficient due to O(N) time complexity per shift operation. FixedQueue provides O(1) dequeue performance
In the benchmark, to really highlight the effect, I used the
--unhandled-rejections=warnflag since it uses the queue even more