benchmark: allow boolean option values in createBenchmark #60129
+29
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
SeokhunEom
force-pushed
the
benchmark-boolean-option
branch
4 times, most recently
from
5e643fc to
bea0f69
Compare
RafaelGSS
approved these changes
Oct 6, 2025
Change createBenchmark to also accept booleans. Update writing-and-running-benchmarks.md and format the md.
Use boolean values for randomUUID benchmark and deprecate benchmark instead of 0/1.
SeokhunEom
force-pushed
the
benchmark-boolean-option
branch
from
bea0f69 to
ad0c9ac
Compare
aduh95
reviewed
Nov 8, 2025
Comment on lines
+5
to
+25
| * [How to write and run benchmarks in Node.js core](#how-to-write-and-run-benchmarks-in-nodejs-core) | ||
| * [Table of contents](#table-of-contents) | ||
| * [Prerequisites](#prerequisites) | ||
| * [HTTP benchmark requirements](#http-benchmark-requirements) | ||
| * [HTTPS benchmark requirements](#https-benchmark-requirements) | ||
| * [HTTP/2 benchmark requirements](#http2-benchmark-requirements) | ||
| * [Benchmark analysis requirements](#benchmark-analysis-requirements) | ||
| * [Running benchmarks](#running-benchmarks) | ||
| * [Setting CPU Frequency scaling governor to "performance"](#setting-cpu-frequency-scaling-governor-to-performance) | ||
| * [Running individual benchmarks](#running-individual-benchmarks) | ||
| * [Calibrating the number of iterations with calibrate-n.js](#calibrating-the-number-of-iterations-with-calibrate-njs) | ||
| * [Running all benchmarks](#running-all-benchmarks) | ||
| * [Specifying CPU Cores for Benchmarks with run.js](#specifying-cpu-cores-for-benchmarks-with-runjs) | ||
| * [Filtering benchmarks](#filtering-benchmarks) | ||
| * [Grouping benchmarks](#grouping-benchmarks) | ||
| * [Comparing Node.js versions](#comparing-nodejs-versions) | ||
| * [Comparing parameters](#comparing-parameters) | ||
| * [Running benchmarks on the CI](#running-benchmarks-on-the-ci) | ||
| * [Creating a benchmark](#creating-a-benchmark) | ||
| * [Basics of a benchmark](#basics-of-a-benchmark) | ||
| * [Creating an HTTP benchmark](#creating-an-http-benchmark) |
Contributor
There was a problem hiding this comment.
Can you please remove this unrelated change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.