benchmark: refactor http benchmarks #59862
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Review requested:
|
nodejs-github-bot
added
benchmark
H4ad
approved these changes
Sep 12, 2025
Member
There was a problem hiding this comment.
Except from the lint issues, LGTM.
It would be great to see if @joyeecheung has any comments on this removal since she introduced it.
Also, maybe you should split the changes in two or more commits to clearly separate the changes (drop double benchmark, remove http benchs from run all)
RafaelGSS
force-pushed
the
refactor-http-benchmark
branch
from
850d07f to
600c564
Compare
According to nodejs/performance#186, HTTP benchmarks usually take a significant amount of time. Leveraging nodejs/performance#80, I have decided to drop the test-double-http(s) benchmarkers as they aren't a reliable source of measurements. From now on, only Autocannon, Wrk and H2 (HTTP/2) are available for HTTP benchmarks. I have also removed the http(s) benchmarks (`http`, `http2`, `https`) from the list of benchmark/run.js all as they deserve a separate namespace and to prevent the node-microbenchmark CI from taking a long time. I will revamp the HTTP benchmarks from Node.js, and this is an initial step. Signed-off-by: RafaelGSS <[email protected]>
RafaelGSS
force-pushed
the
refactor-http-benchmark
branch
from
600c564 to
feacdc8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to nodejs/performance#186, HTTP benchmarks usually take a significant amount of time.
Leveraging nodejs/performance#80, I have decided to drop the test-double-http(s) benchmarkers as they aren't a reliable source of measurements. From now on, only Autocannon, Wrk and H2 (HTTP/2) are available for HTTP benchmarks.
I have also removed the http(s) benchmarks (
http,http2,https) from the list of benchmark/run.js all as they deserve a separate namespace and to prevent the node-microbenchmark CI from taking a long time.I will revamp the HTTP benchmarks from Node.js, and this is an initial step.
cc: @nodejs/performance