http,https,http2: make async disposers idempotent #58832
+19
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
http
jasnell
reviewed
Jun 25, 2025
| @@ -580,10 +578,6 @@ Server.prototype.close = function close() { | |||
| return this; | |||
| }; | |||
|
|
|||
| Server.prototype[SymbolAsyncDispose] = assignFunctionName(SymbolAsyncDispose, async function() { | |||
There was a problem hiding this comment.
Hmm does this make this a semver-major? This becomes a user observable change and if someone happens to be using an ERM polyfill I can imagine removing this breaking things.
There was a problem hiding this comment.
Right, I forgot that disposers graduated from experimental state since v24.2.0.
There was a problem hiding this comment.
Would it be better to split this into two patches, one to make the existing http* overrides idempotent, and another semver-major one to remove them?
LiviaMedeiros
added
the
semver-major
himself65
approved these changes
Jun 25, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58832 +/- ##
==========================================
- Coverage 90.09% 90.08% -0.02%
==========================================
Files 640 640
Lines 188271 188356 +85
Branches 36923 36940 +17
==========================================
+ Hits 169625 169675 +50
- Misses 11386 11402 +16
- Partials 7260 7279 +19
🚀 New features to boost your workflow:
|
github-actions
bot
removed
the
request-ci
anonrig
approved these changes
Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
server[Symbol.asyncDispose]calls not throw after the server is already closed.