Skip to content

vm: expose import phase on SourceTextModule.moduleRequests #58829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

legendecas
Copy link
Member

Expose import phase on vm.SourceTextModule.moduleRequests. This deprecates vm.SourceTextModule.dependencySpecifiers as it does not expose import attributes nor import phase.

Refs: #37648

@legendecas legendecas added the vm Issues and PRs related to the vm subsystem. label Jun 25, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/vm

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 25, 2025
Copy link

codecov bot commented Jun 25, 2025

Codecov Report

Attention: Patch coverage is 97.77778% with 1 line in your changes missing coverage. Please review.

Project coverage is 90.09%. Comparing base (100c6da) to head (7f1891d).

Files with missing lines Patch % Lines
lib/internal/vm/module.js 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58829      +/-   ##
==========================================
- Coverage   90.10%   90.09%   -0.01%     
==========================================
  Files         640      640              
  Lines      188384   188409      +25     
  Branches    36932    36943      +11     
==========================================
+ Hits       169735   169742       +7     
- Misses      11356    11363       +7     
- Partials     7293     7304      +11     
Files with missing lines Coverage Δ
src/module_wrap.cc 72.75% <100.00%> (+0.15%) ⬆️
lib/internal/vm/module.js 98.18% <97.36%> (-0.14%) ⬇️

... and 28 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants