Skip to content

lib: fix getTypeScriptParsingMode jsdoc #58681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

ShenHongFei
Copy link
Contributor

@ShenHongFei ShenHongFei commented Jun 11, 2025

fix type in getTypeScriptParsingMode's jsdoc: @type {string} should be @type {() => TypeScriptMode}

@marco-ippolito

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders

@nodejs-github-bot nodejs-github-bot added module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run. labels Jun 11, 2025
Copy link

codecov bot commented Jun 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (5457443) to head (f89c869).
Report is 80 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58681      +/-   ##
==========================================
+ Coverage   90.03%   90.16%   +0.12%     
==========================================
  Files         635      637       +2     
  Lines      187688   188123     +435     
  Branches    36761    36908     +147     
==========================================
+ Hits       168991   169621     +630     
+ Misses      11499    11242     -257     
- Partials     7198     7260      +62     
Files with missing lines Coverage Δ
lib/internal/modules/typescript.js 97.47% <100.00%> (ø)

... and 50 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
@nodejs-github-bot
Copy link
Collaborator

@ShenHongFei
Copy link
Contributor Author

This test failed, but it seems to have nothing to do with my changes. Can someone help me take a look? What else do I need to do?

https://ci.nodejs.org/job/node-test-binary-windows-js-suites/34833/RUN_SUBSET=3,nodes=win11-COMPILED_BY-vs2022_clang/

@nodejs-github-bot
Copy link
Collaborator

@jakecastelli jakecastelli added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 25, 2025
@anonrig anonrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 26, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/58681
✔  Done loading data for nodejs/node/pull/58681
----------------------------------- PR info ------------------------------------
Title      lib: fix `getTypeScriptParsingMode` jsdoc (#58681)
Author     沈鸿飞 <[email protected]> (@ShenHongFei)
Branch     ShenHongFei:fix-jsdoc -> nodejs:main
Labels     module, author ready, needs-ci
Commits    2
 - lib: fix `getTypeScriptParsingMode` jsdoc
 - Update lib/internal/modules/typescript.js
Committers 1
 - GitHub <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/58681
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/58681
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 11 Jun 2025 16:44:02 GMT
   ✔  Approvals: 2
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58681#pullrequestreview-2932264387
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58681#pullrequestreview-2960192986
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-06-16T16:42:37Z: https://ci.nodejs.org/job/node-test-pull-request/67484/
- Querying data for job/node-test-pull-request/67484/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 58681
From https://github.com/nodejs/node
 * branch                  refs/pull/58681/merge -> FETCH_HEAD
✔  Fetched commits as a705e240b197..f89c869c1b16
--------------------------------------------------------------------------------
[main 3d8e48e31d] lib: fix `getTypeScriptParsingMode` jsdoc
 Author: 沈鸿飞 <[email protected]>
 Date: Thu Jun 12 00:37:32 2025 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
[main cb7ddf4785] Update lib/internal/modules/typescript.js
 Author: 沈鸿飞 <[email protected]>
 Date: Thu Jun 12 02:52:09 2025 +0800
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
lib: fix `getTypeScriptParsingMode` jsdoc

PR-URL: #58681
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

[detached HEAD 86b204addb] lib: fix getTypeScriptParsingMode jsdoc
Author: 沈鸿飞 <[email protected]>
Date: Thu Jun 12 00:37:32 2025 +0800
1 file changed, 1 insertion(+), 1 deletion(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
Update lib/internal/modules/typescript.js

Co-authored-by: Yagiz Nizipli <[email protected]>
PR-URL: #58681
Reviewed-By: Marco Ippolito <[email protected]>
Reviewed-By: Yagiz Nizipli <[email protected]>

[detached HEAD cae839aed6] Update lib/internal/modules/typescript.js
Author: 沈鸿飞 <[email protected]>
Date: Thu Jun 12 02:52:09 2025 +0800
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/15891063969

@marco-ippolito marco-ippolito added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jun 26, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 26, 2025
@nodejs-github-bot nodejs-github-bot merged commit b4c5fb4 into nodejs:main Jun 26, 2025
84 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in b4c5fb4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. module Issues and PRs related to the module subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants