-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
lib: fix getTypeScriptParsingMode
jsdoc
#58681
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58681 +/- ##
==========================================
+ Coverage 90.03% 90.16% +0.12%
==========================================
Files 635 637 +2
Lines 187688 188123 +435
Branches 36761 36908 +147
==========================================
+ Hits 168991 169621 +630
+ Misses 11499 11242 -257
- Partials 7198 7260 +62
🚀 New features to boost your workflow:
|
Co-authored-by: Yagiz Nizipli <[email protected]>
This test failed, but it seems to have nothing to do with my changes. Can someone help me take a look? What else do I need to do? |
Commit Queue failed- Loading data for nodejs/node/pull/58681 ✔ Done loading data for nodejs/node/pull/58681 ----------------------------------- PR info ------------------------------------ Title lib: fix `getTypeScriptParsingMode` jsdoc (#58681) Author 沈鸿飞 <[email protected]> (@ShenHongFei) Branch ShenHongFei:fix-jsdoc -> nodejs:main Labels module, author ready, needs-ci Commits 2 - lib: fix `getTypeScriptParsingMode` jsdoc - Update lib/internal/modules/typescript.js Committers 1 - GitHub <[email protected]> PR-URL: https://github.com/nodejs/node/pull/58681 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58681 Reviewed-By: Marco Ippolito <[email protected]> Reviewed-By: Yagiz Nizipli <[email protected]> -------------------------------------------------------------------------------- ℹ This PR was created on Wed, 11 Jun 2025 16:44:02 GMT ✔ Approvals: 2 ✔ - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/58681#pullrequestreview-2932264387 ✔ - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/58681#pullrequestreview-2960192986 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2025-06-16T16:42:37Z: https://ci.nodejs.org/job/node-test-pull-request/67484/ - Querying data for job/node-test-pull-request/67484/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/main up to date... From https://github.com/nodejs/node * branch main -> FETCH_HEAD ✔ origin/main is now up-to-date - Downloading patch for 58681 From https://github.com/nodejs/node * branch refs/pull/58681/merge -> FETCH_HEAD ✔ Fetched commits as a705e240b197..f89c869c1b16 -------------------------------------------------------------------------------- [main 3d8e48e31d] lib: fix `getTypeScriptParsingMode` jsdoc Author: 沈鸿飞 <[email protected]> Date: Thu Jun 12 00:37:32 2025 +0800 1 file changed, 1 insertion(+), 1 deletion(-) [main cb7ddf4785] Update lib/internal/modules/typescript.js Author: 沈鸿飞 <[email protected]> Date: Thu Jun 12 02:52:09 2025 +0800 1 file changed, 1 insertion(+), 1 deletion(-) ✔ Patches applied There are 2 commits in the PR. Attempting autorebase. Rebasing (2/4) Executing: git node land --amend --yes --------------------------------- New Message ---------------------------------- lib: fix `getTypeScriptParsingMode` jsdochttps://github.com/nodejs/node/actions/runs/15891063969 |
Landed in b4c5fb4 |
fix type in getTypeScriptParsingMode's jsdoc:
@type {string}
should be@type {() => TypeScriptMode}
@marco-ippolito