module: correctly detect top-level await in ambiguous contexts #58646
+93
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58646 +/- ##
==========================================
- Coverage 90.15% 90.06% -0.10%
==========================================
Files 636 640 +4
Lines 188028 188291 +263
Branches 36895 36919 +24
==========================================
+ Hits 169526 169592 +66
- Misses 11231 11399 +168
- Partials 7271 7300 +29
🚀 New features to boost your workflow:
|
addaleax
reviewed
Jun 9, 2025
Ethan-Arrowood
approved these changes
Jun 10, 2025
Ethan-Arrowood
added
the
request-ci
github-actions
bot
removed
the
request-ci
joyeecheung
reviewed
Jun 15, 2025
| @@ -423,3 +423,77 @@ describe('when working with Worker threads', () => { | |||
| strictEqual(signal, null); | |||
| }); | |||
| }); | |||
|
|
|||
| describe('maybe top-level await syntax errors that are not recognized as top-level await errors', () => { | |||
There was a problem hiding this comment.
This test is already too long with too many things mixed together. Can you add the new tests to a new file? https://github.com/nodejs/node/blob/main/doc/contributing/writing-tests.md#how-to-write-a-good-test
There was a problem hiding this comment.
Thanks!
I've moved the test to a new file.
Ethan-Arrowood
approved these changes
Jun 16, 2025
github-actions
bot
removed
the
request-ci
jasnell
reviewed
Jun 21, 2025
src/node_contextify.cc
Outdated
| std::array<std::string_view, 2>{// example: `func(await 1);` | ||
| "missing ) after argument list", | ||
| // example: `if(await 1)` | ||
| "SyntaxError: Unexpected"}; |
There was a problem hiding this comment.
Did the linter/formatter format the code this way?
There was a problem hiding this comment.
Yes, but now that you mention it, it's a weird format.
I've changed the comment's position.
jasnell
approved these changes
Jun 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #58331
Many syntax errors are incorrectly treated as requiring ESM recompilation, but since they can't be clearly distinguished from top-level await-related errors, the current fix ends up handling them together.
From what I can tell by looking at the issues reported on V8, this appears to be a problem on the V8 side, so I will see if a fix can be made there.
https://issues.chromium.org/issues/40070895#comment1
That said, this patch will be necessary until the issue is resolved in V8.