Skip to content

doc: type improvement of file http.md, outgoingMessage.setHeader and outgoingMessage.getHeader section #58189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

doc: type improvement of file http.md, outgoingMessage.setHeader and outgoingMessage.getHeader section #58189

wants to merge 2 commits into from

Conversation

samuel871211
Copy link
Contributor

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels May 6, 2025
@samuel871211
doc: type improvement of file http.md
3998e6f 
`outgoingMessage.setHeader` and `outgoingMessage.getHeader` section
@samuel871211 samuel871211 force-pushed the typeImprovementOfHttpMd branch from fda2418 to 3998e6f Compare May 6, 2025 08:52
@samuel871211
doc: type improvement of file http.md
a9ed0be 
`response.setHeader` and `response.getHeader` section
Ethan-Arrowood
Ethan-Arrowood approved these changes May 8, 2025
View reviewed changes
Copy link
Contributor

@Ethan-Arrowood Ethan-Arrowood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay with this change as it matches the types, but I'd prefer we have some verification this is true based on the implementation. I looked briefly and I think it matches, but may be worth a closer analysis by the author 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ethan-Arrowood Ethan-Arrowood Ethan-Arrowood approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samuel871211 @nodejs-github-bot @Ethan-Arrowood @bjohansebas