tools: lint typescript files

[avivkeller]

Fixes #55702 by enabling typescript-eslint on TypeScript files.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.40%. Comparing base (f38cefa) to head (e46dd39).
Report is 985 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #55709      +/-   ##
==========================================
- Coverage   88.40%   88.40%   -0.01%     
==========================================
  Files         654      654              
  Lines      187746   187815      +69     
  Branches    36126    36134       +8     
==========================================
+ Hits       165978   166038      +60     
+ Misses      15009    15005       -4     
- Partials     6759     6772      +13     

see 44 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[marco-ippolito]

I checkout on the pr, changed a typescript file with invalid format, and run make lint-js-fix and it did not fix the format.

[avivkeller]

Where is the TypeScript file you edited? In my case, it appears to be correctly linting TypeScript files.

Most places where TypeScript files exist aren't linted, for example, the test fixtures are excluded from linting entirely

[avivkeller]

typescript-eslint can also replace the Babel parser (removing 44 deps from our ESLint configuration), should I do that here, or in a follow up?

[marco-ippolito]

typescript-eslint can also replace the Babel parser (removing 44 deps from our ESLint configuration), should I do that here, or in a follow up?

Follow up would be better
I'm surprised there is no linting error 🤔

[marco-ippolito]

On which typescript files have you tested it?
It's not linting the typings folder.

I think I would actually create a command make lint-ts and run it also in the test/fixtures/typescript, typing folder and examples with the ts extension. Otherwise it seems not doing anything

[avivkeller]

test/fixtures/typescript

That folder contains a lot of lint errors (for example, unreachable code), as with most of the fixtures, and I think it's best to not lint.

typings

I'll edit the config to lint that folder, now that there is typescript support.

I think I would actually create a command make lint-ts

IMO keeping it as js is okay, and if something changes, there can always be a follow-up.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/63600/

[marco-ippolito]

@avivkeller are you still interested in landing this PR?

[avivkeller]

It's been several months, and I no longer have the bandwidth to continue with this, apologies.