Skip to content

src: avoid copying string in fs_permission #47746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2023
Merged

src: avoid copying string in fs_permission #47746

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/permission/fs_permission.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ void FSPermission::Apply(const std::string& allow, PermissionScope scope) {
}
}

void FSPermission::GrantAccess(PermissionScope perm, std::string res) {
void FSPermission::GrantAccess(PermissionScope perm, const std::string& res) {
const std::string path = WildcardIfDir(res);
if (perm == PermissionScope::kFileSystemRead) {
granted_in_fs_.Insert(path);
Expand Down
2 changes: 1 addition & 1 deletion src/permission/fs_permission.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ class FSPermission final : public PermissionBase {
};

private:
void GrantAccess(PermissionScope scope, std::string param);
void GrantAccess(PermissionScope scope, const std::string& param);
void RestrictAccess(PermissionScope scope,
const std::vector<std::string>& params);
// fs granted on startup
Expand Down