Skip to content

Conversation

@nodejs-github-bot
Copy link
Collaborator

This is an automated update of lint-md-dependencies to [email protected] [email protected].

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Dec 4, 2021
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that there are a lot of changes in comments. Could we remove the comments from the rollup output?

@Trott
Copy link
Member

Trott commented Dec 5, 2021

I see that there are a lot of changes in comments. Could we remove the comments from the rollup output?

We could use https://www.npmjs.com/package/rollup-plugin-cleanup. That involves adding another dependency to tools/lint-md/package.json. The module hasn't been updated in over a year. But it would probably work.

Another option is we could minify the output, but that will have the opposite effect of what I think you want because it would make diffs bigger and more difficult to review.

@Trott
Copy link
Member

Trott commented Dec 5, 2021

I see that there are a lot of changes in comments. Could we remove the comments from the rollup output?

We could use https://www.npmjs.com/package/rollup-plugin-cleanup. That involves adding another dependency to tools/lint-md/package.json. The module hasn't been updated in over a year. But it would probably work.

Another option is we could minify the output, but that will have the opposite effect of what I think you want because it would make diffs bigger and more difficult to review.

#41092

nodejs-github-bot pushed a commit that referenced this pull request Dec 7, 2021
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
@Trott Trott closed this Dec 12, 2021
@Trott Trott deleted the actions/tools-update-lint-md-dependencies branch December 12, 2021 13:14
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Refs: nodejs#41081 (comment)

PR-URL: nodejs#41092
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Refs: #41081 (comment)

PR-URL: #41092
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Tobias Nießen <[email protected]>
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Tierney Cyren <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants