Skip to content

src: print native module id on native module not found #39460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
legendecas wants to merge 3 commits into from
Closed

src: print native module id on native module not found #39460

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
784adc8
src: print native module id on native module not found
legendecas Jul 20, 2021
edc7eb6
fixup! src: print native module id on native module not found
legendecas Jul 20, 2021
ae0e8aa
fixup! src: print native module id on native module not found
legendecas Jul 20, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion src/node_native_module.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,7 +224,10 @@ MaybeLocal<String> NativeModuleLoader::LoadBuiltinModuleSource(Isolate* isolate,
isolate, contents.c_str(), v8::NewStringType::kNormal, contents.length());
#else
const auto source_it = source_.find(id);
CHECK_NE(source_it, source_.end());
if (UNLIKELY(source_it == source_.end())) {
fprintf(stderr, "Cannot find native builtin. \"%s\"", id);
ABORT();
}
return source_it->second.ToStringChecked(isolate);
#endif // NODE_BUILTIN_MODULES_PATH
}
Expand Down