Skip to content

doc: run license-builder #39360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
github-actions wants to merge 1 commit into from
Closed

doc: run license-builder #39360

github-actions wants to merge 1 commit into from

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Jul 12, 2021

License is likely out of date. This is an automatically generated PR by the license-builder.yml GitHub Action, which runs license-builder.sh and submits a new PR or updates an existing PR.

@github-actions github-actions bot added the meta Issues and PRs related to the general management of the project. label Jul 12, 2021
devsnek
devsnek previously approved these changes Jul 12, 2021
View reviewed changes
@devsnek devsnek dismissed their stale review July 12, 2021 00:13

misread

@devsnek
Copy link
Member

devsnek commented Jul 12, 2021

cc @legendecas

@legendecas
Copy link
Member

legendecas commented Jul 12, 2021

A file from gtest is located at src/gtest too: https://github.com/nodejs/node/blob/master/src/gtest/gtest_prod.h. If I understand correctly, that should be listed at LICENSE too?

@legendecas legendecas mentioned this pull request Jul 12, 2021
Closed
@targos
Copy link
Member

targos commented Jul 12, 2021

I'm curious, what's the change that introduced this?

@legendecas
Copy link
Member

legendecas commented Jul 13, 2021

@targos 392213a this one

targos
targos requested changes Jul 14, 2021
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#39361

@targos targos closed this Jul 16, 2021
@targos targos deleted the create-or-update-pull-request-action branch July 16, 2021 16:02
@targos
Copy link
Member

targos commented Jul 16, 2021

Fixed in #39386

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@targos targos targos requested changes

@jasnell jasnell jasnell approved these changes

+1 more reviewer

@devsnek devsnek devsnek left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@devsnek @legendecas @targos @jasnell @create-or-update-pull-request