streams: use finished for pump #39203
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-use existing compay logic for pump by using finished.
Member
Author
|
@nodejs/streams |
ronag
commented
Jun 30, 2021
| ); | ||
|
|
||
| writableLike.emit('close'); | ||
| } |
Member
Author
There was a problem hiding this comment.
These test are just for very edge case mostly made up compat scenarios and actually do not align with compat as implemented in finished. I just removed them,
ronag
added
the
author ready
Collaborator
Contributor
|
s/compay/compat/ in commit message? |
benjamingr
approved these changes
Jun 30, 2021
aduh95
reviewed
Jul 1, 2021
Co-authored-by: Antoine du Hamel <[email protected]>
Member
Author
|
Landed in 3203396 |
ronag
added a commit
that referenced
this pull request
Jul 2, 2021
Re-use existing compat logic for pump by using finished. PR-URL: #39203 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
Re-use existing compat logic for pump by using finished. PR-URL: #39203 Reviewed-By: Matteo Collina <[email protected]> Reviewed-By: Benjamin Gruenbaum <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-use existing compay logic for pump by using finished. Also cleans up logic a bit.