typings: Add a few JSDoc typings for the net lib module #38953
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
needs-ci
VoltrexKeyva
reviewed
Jun 6, 2021
lib/net.js
Outdated
Comment on lines
165
to
171
| /** | ||
| * Creates a new TCP or IPC server | ||
| * @param {{ | ||
| * allowHalfOpen?: boolean; | ||
| * pauseOnConnect?: boolean; | ||
| * }} options | ||
| * @param {Function} connectionListener |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * Creates a new TCP or IPC server | |
| * @param {{ | |
| * allowHalfOpen?: boolean; | |
| * pauseOnConnect?: boolean; | |
| * }} options | |
| * @param {Function} connectionListener | |
| /** | |
| * Creates a new TCP or IPC server | |
| * @param {{ | |
| * allowHalfOpen?: boolean; | |
| * pauseOnConnect?: boolean; | |
| * }} [options] | |
| * @param {Function} [connectionListener] |
These 2 parameters are optional + formatting to keep consistency with the JSDocs in other lib modules.
jasnell
approved these changes
Jun 7, 2021
targos
approved these changes
Jul 11, 2021
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
PR-URL: #38953 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Member
|
Landed in c4f8363 |
targos
pushed a commit
that referenced
this pull request
Jul 11, 2021
PR-URL: #38953 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
targos
pushed a commit
that referenced
this pull request
Sep 4, 2021
PR-URL: #38953 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Michaël Zasso <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a few JSDoc typings for the
netlib module.