[v8.x backport] dns: fix crash while setting server during query #17778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
gibfahn
force-pushed
the
v8.x-staging
branch
from
563f1f6 to
6fa51d6
Compare
XadillaX
force-pushed
the
backport-14891
branch
from
a928c33 to
7fed623
Compare
|
/cc @addaleax @bnoordhuis |
Fix this issue follow these two points: 1. Keep track of how many queries are currently open. If `setServers()` is called while there are open queries, error out. 2. For `Resolver` instances, use option 1. For dns.setServers(), just create a fresh new default channel every time it is called, and then set its servers list. Fixes: nodejs#14734
XadillaX
force-pushed
the
backport-14891
branch
from
7fed623 to
c34ee3c
Compare
|
/cc @addaleax @bnoordhuis |
bnoordhuis
approved these changes
Jan 25, 2018
gibfahn
pushed a commit
that referenced
this pull request
Feb 19, 2018
Fix this issue follow these two points: 1. Keep track of how many queries are currently open. If `setServers()` is called while there are open queries, error out. 2. For `Resolver` instances, use option 1. For dns.setServers(), just create a fresh new default channel every time it is called, and then set its servers list. Fixes: #14734 PR-URL: #14891 Backport-PR-URL: #17778 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Tobias Nießen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #14891
Fix this issue follow these two points:
setServers()is called while there are open queries, error out.
Resolverinstances, use option 1. For dns.setServers(), justcreate a fresh new default channel every time it is called, and then
set its servers list.
Fixes: #14734
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
dns, cares