(v6.x backport) process: add --redirect-warnings command line argument #14480
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
Contributor
Author
|
Parking this until the next semver minor release of 6.x, see #14418 (comment) @nodejs/lts |
sam-github
added
lts-watch-v6.x
semver-minor
MylesBorins
force-pushed
the
v6.x-staging
branch
from
7b8fcf8 to
f4691bb
Compare
MylesBorins
force-pushed
the
v6.x-staging
branch
6 times, most recently
from
f9419c2 to
403c465
Compare
MylesBorins
force-pushed
the
v6.x-staging
branch
2 times, most recently
from
aaf4e13 to
31f572c
Compare
Contributor
|
Needs a rebase. Good to land |
sam-github
force-pushed
the
v6.x-backport-redirect-warnings
branch
2 times, most recently
from
f6063fc to
33c45ce
Compare
Contributor
Author
|
Landed in adf6d16 |
Contributor
|
backing this out of v6.x-staging it is not ready to land yet. We will land the minors next month when we are prepping the minor release |
sam-github
force-pushed
the
v6.x-backport-redirect-warnings
branch
from
33c45ce to
a76b3b8
Compare
4 tasks
MylesBorins
force-pushed
the
v6.x-staging
branch
from
b811464 to
2c8fe97
Compare
Contributor
|
landed in 158906b707 |
Contributor
|
@sam-github I had to back this out as it was breaking the build. Can you please rebase and confirm that this compiles |
MylesBorins
force-pushed
the
v6.x-staging
branch
from
355249a to
0597d3f
Compare
sam-github
force-pushed
the
v6.x-backport-redirect-warnings
branch
2 times, most recently
from
b879e03 to
2604584
Compare
Contributor
Author
|
rebased again, and it compiles for me, I'm running tests locally and on ci: https://ci.nodejs.org/job/node-test-pull-request/10590/ |
Contributor
Author
The --redirect-warnings command line argument allows process warnings to be written to a specified file rather than printed to stderr. Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable. If the specified file cannot be opened or written to for any reason, the argument is ignored and the warning is printed to stderr. If the file already exists, it will be appended to. PR-URL: nodejs#10116 Reviewed-By: Michael Dawson <[email protected]> Reviewed-By: Michal Zasso <[email protected]> Reviewed-By: Fedor Indutny <[email protected]>
Mutations of the environment can invalidate pointers to environment variables, so make `secure_getenv()` copy them out instead of returning pointers. This is the part of nodejs#11051 that applies to nodejs@03e89b3
sam-github
force-pushed
the
v6.x-backport-redirect-warnings
branch
from
2604584 to
63c1ce4
Compare
Contributor
Author
|
replaced by #12677 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The --redirect-warnings command line argument allows process warnings
to be written to a specified file rather than printed to stderr.
Also adds an equivalent NODE_REDIRECT_WARNINGS environment variable.
If the specified file cannot be opened or written to for any reason,
the argument is ignored and the warning is printed to stderr.
If the file already exists, it will be appended to.
PR-URL: #10116
Reviewed-By: Michael Dawson [email protected]
Reviewed-By: Michal Zasso [email protected]
Reviewed-By: Fedor Indutny [email protected]
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)