Skip to content

[meta] realpath issues in v6 #7726

Closed
Closed
@saghul

Description

@saghul

Overview

There are a number of problems related to the realpath change in #3594. This issue aims to serve a single entry point to those, with the hope that we have a clear picture and are able to address them one way or another.

Please: Do not report new issues here, this is a collection of the currently existing ones.

Current state

Bad. Some of these issues have PRs addressing a specific issue, but none fix all of them.

Original reasoning

Following the issue trail I can only see performance as the argument for creating uv_fs_realpath and using it in node:

Way forward(?)

After scratching my head for a while I have no other suggestion than to revert back to the JS implementation. Since we changed the API to remove the cache argument, which was needed for performance, I suggest we keep the cache private, thus avoiding yet another API change.

I'll update the libuv documentation so nobody tries to bring this up again in Node v103.x, or at least not without validating it solves all the aforementioned problems.

Suggestions / alternatives are more than welcome, but at this point it's all or nothing, we either have a plan for fixing all the problems or we revert, IMHO.

Metadata

Metadata

Assignees

No one assigned

    Labels

    fsIssues and PRs related to the fs subsystem / file system.metaIssues and PRs related to the general management of the project.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions