Skip to content

dns test cases failures when upgrading to c-ares 1.21.0/1.22.0 #50741

Closed
@bradh352

Description

@bradh352

Version

No response

Platform

No response

Subsystem

No response

What steps will reproduce the bug?

Run node-js tests when linking with c-ares 1.21.0 or 1.22.0. Observe failures to parallel/test-dns-resolveany and parallel/test-dns-resolveany-bad-ancount.

How often does it reproduce? Is there a required condition?

100% of the time

What is the expected behavior? Why is that the expected behavior?

Test cases should pass

What do you see instead?

Test cases fail

Additional information

See c-ares/c-ares#621 with further discussion.

For parallel/test-dns-resolveany, c-ares now conforms with RFC 7208 and concatenates multiple strings for the same TXT record, hence the failure in this test case as it assumes non-conformance like previous c-ares versions.

For parallel/test-dns-resolveany-bad-ancount, it appears a malformed response packet is sent making it completely unparseable, so c-ares is now days throwing away the response assuming it will get a legitimate response (and therefore goes through retry cycles). c-ares plans on adding support for RFC 9018 which requires full message parsing to determine if the response may be spoofed and should be tossed (and therefore wait for the legitimate response). I think this test case should be changed to simply look for a result other than ARES_SUCCESS.

@gjasny

Metadata

Metadata

Assignees

No one assigned

    Labels

    caresIssues and PRs related to the c-ares dependency or the cares_wrap binding.dnsIssues and PRs related to the dns subsystem.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions