Skip to content

test: flaky parallel/test-crypto-dh #3881

Closed
@bnoordhuis

Description

@bnoordhuis
not ok 132 test-crypto-dh.js
# TIMEOUT
  ---
  duration_ms: 120.60

I can reproduce this locally up to a point:

$ time out/Release/node test/parallel/test-crypto-dh.js

real    0m1.264s
user    0m1.254s
sys     0m0.010s

$ time out/Release/node test/parallel/test-crypto-dh.js

real    0m13.104s
user    0m13.096s
sys     0m0.009s

$ time out/Release/node test/parallel/test-crypto-dh.js

real    0m3.611s
user    0m3.603s
sys     0m0.007s

The high variance is because the test has to search for suitable prime numbers:

            |--75.34%-- BN_mod_word
            |          |
            |          |--99.79%-- BN_generate_prime_ex
            |          |          DH_generate_parameters_ex
            |          |          node::crypto::DiffieHellman::New
            |          |          v8::internal::FunctionCallbackArguments::Call
            |          |          v8::internal::Builtin_HandleApiCallConstruct
            |          |          Stub:CEntryStub
            |          |          Builtin:JSConstructStubApi
            |          |          LazyCompile:~DiffieHellman crypto.js:340
            |          |          Builtin:JSConstructStubGeneric
            |          |          LazyCompile:~DiffieHellman crypto.js:340
            |          |          Builtin:ArgumentsAdaptorTrampoline
            |          |          Function:~ /home/bnoordhuis/src/v1.x/test/parallel/test-crypto-dh.js:1
            |          |          Builtin:FunctionApply
            |          |          LazyCompile:~Module._compile module.js:377
            |          |          LazyCompile:~Module._extensions..js module.js:428
            |          |          LazyCompile:~Module.load module.js:345
            |          |          LazyCompile:Module._load module.js:271
            |          |          LazyCompile:~Module.runMain module.js:453
            |          |          LazyCompile:~startup node.js:13
            |          |          Function:~ node.js:10
            |          |          Builtin:JSEntryTrampoline
            |          |          Stub:JSEntryStub
            |          |          v8::internal::Execution::Call
            |          |          v8::Function::Call
            |          |          v8::Function::Call
            |          |          node::LoadEnvironment
            |          |          node::Start
            |          |          __libc_start_main
            |          |          0xc796258d4c544155

I think we either have to give this test (virtually) unlimited running time or move it to test/pummel.

Metadata

Metadata

Assignees

No one assigned

    Labels

    cryptoIssues and PRs related to the crypto subsystem.testIssues and PRs related to the tests.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions