Skip to content

Document about CI results expected in the onboarding PR #18835

Closed
@joyeecheung

Description

@joyeecheung

Refs: #18824 (comment)

I believe the current practice is:

  1. Ask the people getting onboard to launch a full CI (to make sure they can do that), and paste the link in the PR
  2. After the linter goes green, stop the CI (since it's just a documentation change we don't really need to get a green full CI, also unfortunately these days the full CI are almost never green..)
  3. We don't require onboarding PR to wait for 48/72 hours, so with at least one LGTM and a green linter , the PR is ready to land. How long the PR needs to wait depends on the author. It's OK to wait for < 30mins, IMO.

Metadata

Metadata

Assignees

No one assigned

    Labels

    docIssues and PRs related to the documentations.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions