Description
This is a tracking issue for the remaining bits of work around converting errors thrown in C++ land over to use internal/errors. There is still quite a bit here that needs to be done.
Currently, quite a few functions defined at the C++ layer and exposed through the process.bindings() perform input argument type checking at the C++ level and use some variation of env->ThrowTypeError() to report the error back up to JavaScript. As much as possible, these should be modified to move the input argument type checking up into the JavaScript layer before the binding function is called, and the checks occurring at the C++ level should be changed into in appropriate CHECK() statement. There are quite a few of these and it will be difficult to enumerate them all here. (Note also that this should include range checking)
The general pattern for most functions is: Type check the inputs, perform some function, handle the result. In many cases, if the result is an error, some variation of env->ThrowError() is used to report the error back up to Javascript. As much as possible, these should be converted to return an error code back to JavaScript in some way then have the actual Error object generated within JavaScript.
There are a few very rare cases where the C++ objects and functions are exposed directly to end users as public APIs. In these cases, we either need to introduce a JavaScript wrapper or we will have to add new internal C++ env->Throw variants that accept an error code.
Overall, the goal is to move as many of the Error creations into JavaScript as possible, then deal with the ones we absolutely cannot move separately.
/cc @mhdawson