Flaky stringbytes-external-exceed-max tests on FreeBSD 10-64

[joyeecheung]

• Version: master
• Platform: freebsd10-64
• Subsystem: test

Sample

This is constantly showing up in unrelated PR jobs.

not ok 1807 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max
  ---
  duration_ms: 178.295
  severity: fail
  stack: |-
    timeout
  ...

not ok 1810 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary
  ---
  duration_ms: 127.104
  severity: fail
  stack: |-
    timeout
  ...

not ok 1811 addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex
  ---
  duration_ms: 154.918
  severity: fail
  stack: |-
    timeout

[joyeecheung]

cc @nodejs/testing @nodejs/platform-freebsd

[targos]

These tests started to timeout after the update to V8 6.2. It is most likely because the maximum string size is now 1GB on 64-bit systems.

[bnoordhuis]

#16358

[Trott]

A few thoughts on this:

• Maybe we just need a machine in CI with more RAM or something? (@nodejs/build)

• I wonder if it's just a matter of tweaking common.enoughTestMem to skip on our FreeBSD 10 host?

• Perhaps these tests should be moved to pummel?

• Are removing these tests entirely a reasonable possibility?

[Trott]

These tests are skipped on machines with less than 1 Gb of RAM. This machine that we're seeing failure on has 1.7-ish Gb of RAM. I'd be cool with moving the threshold up to 1.99 Gb of RAM, so 2Gb or more of RAM runs the test. Not sure how many other machines in CI that might cause the tests to skip on, but honestly, if these tests are only run on one or two platforms in CI, that's probably fine. Thoughts? @nodejs/testing @nodejs/build

[Trott]

Increasing common.enoughTestMem to 1.75 Gb seemed like a good idea to me, so: #16374