Skip to content

restructure the directory layout #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 17, 2017
Merged

Conversation

joyeecheung
Copy link
Member

  • steps -> components because I think that's a better name.
  • Put queries under lib
  • ./bin/get_metadata.js -> ./bin/get-metadata

New structure:

.
├── CONTRIBUTING.md
├── LICENSE
├── README.md
├── appveyor.yml
├── bin
│   └── get-metadata
├── components
│   └── metadata.js
├── lib
│   ├── queries
│   │   ├── PR.gql
│   │   └── ...
│   ├── args.js
│   └── ...
├── package-lock.json
├── package.json
└── test
    ├── fixtures
    │   └── ...
    └── unit
        └── ...

@codecov
Copy link

codecov bot commented Nov 16, 2017

Codecov Report

Merging #113 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   91.01%   91.01%           
=======================================
  Files          14       14           
  Lines         534      534           
=======================================
  Hits          486      486           
  Misses         48       48
Impacted Files Coverage Δ
lib/pr_data.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c42f35...07c527c. Read the comment docs.

@joyeecheung
Copy link
Member Author

This is spinning-off from my local branch of #106 , I am going to put the git sub commands into components. Also if we were going to put other tools managed by the automation team into this repo, I would also put the subtrees into components as well.

@joyeecheung
Copy link
Member Author

CI looks happy, trivial change, so I'll merge this now.

@joyeecheung joyeecheung merged commit 5f0df35 into nodejs:master Nov 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant