Skip to content

fix: drop required node to <=14.0.0 #6

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
RafaelGSS merged 1 commit into from
Jan 27, 2023
Merged

fix: drop required node to <=14.0.0 #6

RafaelGSS merged 1 commit into from
Jan 27, 2023

Conversation

@srl295
Copy link
Member

@srl295 srl295 commented Jan 27, 2023 •
edited
Loading

subset of 4f25898 from #3

Fixes: #2

Co-authored-by: Jordan Harband @ljharb

@srl295 @ljharb
fix: drop required node to 12
0f6d7ea 
subset of 4f25898

Fixes: nodejs#2

Co-authored-by: Jordan Harband <[email protected]>
@srl295
Copy link
Member Author

srl295 commented Jan 27, 2023

@ljharb

ljharb
ljharb approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about running the tests on node 12? we may as well reopen #3 ;-)

@srl295
Copy link
Member Author

srl295 commented Jan 27, 2023

what about running the tests on node 12? we may as well reopen #3 ;-)

this says node 12 is ALL GOOD at the moment.

@RafaelGSS RafaelGSS changed the title fix: drop required node to 12 fix: drop required node to 14.0.0 Jan 27, 2023
@RafaelGSS RafaelGSS changed the title fix: drop required node to 14.0.0 fix: drop required node to <=14.0.0 Jan 27, 2023
@srl295 srl295 mentioned this pull request Jan 27, 2023
Closed
@RafaelGSS
Copy link
Member

RafaelGSS commented Jan 27, 2023

The tests will be included at #5

RafaelGSS
RafaelGSS approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@RafaelGSS RafaelGSS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@RafaelGSS RafaelGSS merged commit af04687 into nodejs:main Jan 27, 2023
@trivikr trivikr mentioned this pull request Oct 20, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes

@RafaelGSS RafaelGSS RafaelGSS approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

bug: needs a minimum version check

3 participants

@srl295 @RafaelGSS @ljharb