Detect Windows incompatible filenames in CI

[joaocgreis]

@nodejs/jenkins-admins

When npm was updated to 3.6.0 in master (nodejs/node#4958), some files were accidentally included that cause git issues checking out in Windows (nodejs/node#5094).

After nodejs/node#5211 nodejs/node#5369 or nodejs/node#5212 land, I plan to add this to node-compile-windows, to prevent the same problem from happening again:

:: https://github.com/nodejs/node/issues/5094
ECHO OFF
FOR /F %%F IN ('git status --porcelain') DO (
  git status
  echo.
  echo ERROR: Workspace cannot be cleaned, possible problem with committed file names
  exit /b 1
)
ECHO ON

Tests:

• master: https://ci.nodejs.org/job/reis-extrafiles/6/nodes=win-vs2015/console
• deps: upgrade to npm 3.7.2 node#5211 : https://ci.nodejs.org/job/reis-extrafiles/7/nodes=win-vs2015/console
• deps: remove unnecessary files node#5212 : https://ci.nodejs.org/job/reis-extrafiles/8/nodes=win-vs2015/console

[rvagg]

great, tho I'm wondering if we shouldn't @ that or something to prevent the "ERROR" text from showing up even when it's working fine, a quick scan or a ctrl-f will show up that text and may be easy to misread.

[joaocgreis]

Added ECHO OFF/ON instead to make it clear that something is happening behind the scenes.

• master: https://ci.nodejs.org/job/reis-extrafiles/11/nodes=win-vs2015/console
• deps: upgrade to npm 3.7.3 node#5369 : https://ci.nodejs.org/job/reis-extrafiles/12/nodes=win-vs2015/console

[joaocgreis]

Added to job.