Skip to content

MNT: Add and apply pre-commit configuration #1169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jan 2, 2023
Merged

Conversation

effigies
Copy link
Member

@effigies effigies commented Jan 1, 2023

Closes #1168.

@effigies effigies mentioned this pull request Jan 1, 2023
@codecov
Copy link

codecov bot commented Jan 1, 2023

Codecov Report

Base: 92.38% // Head: 92.38% // No change to project coverage 👍

Coverage data is based on head (8f8cae3) compared to base (8f8cae3).
Patch has no changes to coverable lines.

❗ Current head 8f8cae3 differs from pull request most recent head ab00ba5. Consider uploading reports for the commit ab00ba5 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1169   +/-   ##
=======================================
  Coverage   92.38%   92.38%           
=======================================
  Files          98       98           
  Lines       12257    12257           
  Branches     2520     2520           
=======================================
  Hits        11324    11324           
  Misses        612      612           
  Partials      321      321           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@effigies
Copy link
Member Author

effigies commented Jan 1, 2023

LGTM. I broke it up so that the configuration changes are not in the same commits as the style changes. Please merge if you're happy with this.

@effigies effigies added this to the 5.0.0 milestone Jan 2, 2023
@ZviBaratz
Copy link
Contributor

Thank you! I'll work on improving the granularity of my commits.

@ZviBaratz ZviBaratz merged commit 42cbe5d into master Jan 2, 2023
@ZviBaratz ZviBaratz deleted the mnt/pre-commit branch January 2, 2023 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrate pre-commit
2 participants