-
Notifications
You must be signed in to change notification settings - Fork 138
Tests/improve nfr logging #3872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tataruty
wants to merge
11
commits into
main
Choose a base branch
from
tests/improve_nfr_logging
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8b08c8c
to
3a12532
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3872 +/- ##
==========================================
- Coverage 95.19% 86.83% -8.37%
==========================================
Files 1 128 +127
Lines 229 16500 +16271
Branches 62 62
==========================================
+ Hits 218 14328 +14110
- Misses 11 1994 +1983
- Partials 0 178 +178 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8da6183
to
e548899
Compare
sjberman
reviewed
Sep 8, 2025
e1f3c02
to
5d0d9e6
Compare
e548899
to
e03b181
Compare
sjberman
reviewed
Sep 9, 2025
e03b181
to
fa481dd
Compare
fa481dd
to
19b59f1
Compare
5d0d9e6
to
5e8513d
Compare
19b59f1
to
9107bc8
Compare
9107bc8
to
802463f
Compare
sjberman
reviewed
Sep 10, 2025
5e8513d
to
e9fc351
Compare
fdd1c0a
to
56940da
Compare
096c177
to
3181a4c
Compare
e9fc351
to
bc729b5
Compare
c774437
to
fa83170
Compare
Base automatically changed from
tests/improve_functional_tests_logging
to
main
September 11, 2025 17:09
fa83170
to
10392e7
Compare
10392e7
to
d757143
Compare
sjberman
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Problem: As a developer of NGF
I want the NFR and functional tests to log as they execute
So I can more easily debug a failure when it occurs.
Solution: - Log statements are added to all non-functional and functional tests to include assertions, requests, responses, and anywhere there is a chance for an error to occur.
Testing: Tested with Plus and without, compared failures output with new logging and without
Closes ##2449
Checklist
Before creating a PR, run through this checklist and mark each as complete.
Release notes