Update Angular version and fix NgClass directive #50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In angular/angular#53831 `NgClass` directive constructor signature was updated, which is a breaking change for Angular Flex Layout. This change updates the signature by removing `iterableDiffers` and `keyValueDiffers`, which are not used anymore.
Contributor
|
@skovalyov thanks for the PR, I was looking at this over the weekend and thought that this seemed like the obvious solution, but it just felt too easy, plus I wasn't sure if that would break anything else, though all unit tests passed. I will merge your PR into main and into the 17 branch as soon as I can, again thanks for the PR |
DuncanFaulkner
added a commit
that referenced
this pull request
Jan 16, 2024
* Merge 17 branch into main (#46) * feat(project): upgrade to Angular 17 * fix(update): issues with linting - still using tslint needs upgrading to eslint * fix(update): fix yarn install to latest node * fix(update): fix local test browser node version * chore(changelog): update changelog * Update README.md (#47) * fix(update): update orbs in CI * Update Angular version and fix NgClass directive (#50) In angular/angular#53831 `NgClass` directive constructor signature was updated, which is a breaking change for Angular Flex Layout. This change updates the signature by removing `iterableDiffers` and `keyValueDiffers`, which are not used anymore. * fix(package): update package json to match yarn lock for browser-sync-client * fix(package): remove package lock file * fix(etag): removed etag * fix(yarn): removed mitt.1.2 * fix(yarn): lock issues failing CI * fix(typescript): version of typescript was too high * chore:(build): create release 17.0.1 --------- Co-authored-by: Sergey Kovalyov <[email protected]>
|
There is release tag in GH, but v17.0.1 is missing in npm. |
Contributor
|
@minijus I had pushed the GH release but it was getting late and just didn't get to it - will try and do it now, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix proposal for ngx-layout/issues#49
In angular/angular#53831
NgClassdirective constructor signature was updated, which is a breaking change for Angular Flex Layout. This change updates the signature by removingiterableDiffersandkeyValueDiffers, which are not used anymore.