[1주차] 3단계 #36
Open
[1주차] 3단계 #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
에뮬레이터 실행 후 설정이 자동 변경된 사항
Kiboom
approved these changes
Nov 13, 2022
| ? null | ||
| : () { | ||
| menuCounter.minus(); | ||
| }, |
There was a problem hiding this comment.
// 1번 방식
IconButton(
onPressed: () {
menuCounter.minus();
},
),
// 2번 방식
IconButton(
onPressed: menuCounter.minus
),함수를 인자로 넘기는 방식에는 크게 위의 두 가지 방식이 있습니다 !
수진님께서는 1번 방식을 사용해주셨는데요,
1번처럼 익명 함수로 호출하는 것보다 2번처럼 함수를 직접 인자로 넘기는 것이
성능 및 가독성 측면에서 더욱 유리하고, 권장되는 방식입니다 ! 😀
참고로 2번과 같은 방식을 tear-off라고 부릅니다.
자세한 내용은 아래 영상을 참고해보시기 바래요 !
| required storeName, | ||
| required storeImage, | ||
| }) : _storeName = storeName, | ||
| _storeImage = storeImage, |
There was a problem hiding this comment.
멤버 변수들을 private으로 잘 변경해주셨고,
파라미터 명에도 _을 잘 없애주셨습니다 ! 💯👏
|
|
||
| var _menuCount = 1; | ||
|
|
||
| int get menuCount => _menuCount; |
| var _menuPrice = 18000; | ||
| var _totalPrice = format.format(_deliveryPrice + _menuPrice); | ||
| const deliveryPrice = 3000; | ||
| const menuPrice = 18000; |
| icon: Icon(Icons.add), | ||
| onPressed: () { | ||
| menuCounter.add(); | ||
| }, |
| @@ -11,7 +13,8 @@ class MyApp extends StatelessWidget { | |||
| @override | |||
| Widget build(BuildContext context) { | |||
| return MaterialApp( | |||
| home: CartScreen(), | |||
| home: ChangeNotifierProvider( | |||
| create: (context) => MenuCounterModel(), child: CartScreen()), | |||
There was a problem hiding this comment.
아래처럼 마지막 인자 뒤에 ,를 넣어주면, 더 가독성 좋게 포맷팅이 될 거에요!
home: ChangeNotifierProvider(
create: (context) => MenuCounterModel(),
child: CartScreen(),
), ^ 콤마 추가!
Kiboom
requested changes
Nov 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.